Re: [PATCH 1/2] powerpc/kdump: Add missing optional dummy functions
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2018-02-13 11:49:30
Also in:
lkml
Guenter Roeck [off-list ref] writes:
If KEXEC_CORE is not enabled, PowerNV builds fail as follows.
arch/powerpc/platforms/powernv/smp.c: In function 'pnv_smp_cpu_kill_self':
arch/powerpc/platforms/powernv/smp.c:236:4: error:
implicit declaration of function 'crash_ipi_callback'
Add dummy function calls, similar to kdump_in_progress(), to solve the
problem.
Fixes: 4145f358644b ("powernv/kdump: Fix cases where the kdump kernel ...")Personally I prefer these untruncated.
Cc: Balbir Singh <bsingharora@gmail.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Nicholas Piggin <npiggin@gmail.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- arch/powerpc/include/asm/kexec.h | 6 ++++++ 1 file changed, 6 insertions(+)
Thanks. Nathan sent a fix for this a few days ago, but I like this version because it uses the existing #ifdefs. I've taken this version but used the subject from his patch. cheers
quoted hunk ↗ jump to hunk
diff --git a/arch/powerpc/include/asm/kexec.h b/arch/powerpc/include/asm/kexec.h index 9dcbfa6bbb91..d8b1e8e7e035 100644 --- a/arch/powerpc/include/asm/kexec.h +++ b/arch/powerpc/include/asm/kexec.h@@ -140,6 +140,12 @@ static inline bool kdump_in_progress(void) return false; } +static inline void crash_ipi_callback(struct pt_regs *regs) { } + +static inline void crash_send_ipi(void (*crash_ipi_callback)(struct pt_regs *)) +{ +} + #endif /* CONFIG_KEXEC_CORE */ #endif /* ! __ASSEMBLY__ */ #endif /* __KERNEL__ */-- 2.7.4