"Alastair D'Silva" [off-list ref] writes:

On Wed, 2018-02-21 at 17:43 +1100, Balbir Singh wrote:

quoted

On Wed, Feb 21, 2018 at 3:57 PM, Alastair D'Silva <alastair@au1.ibm.c
om> wrote:

quoted

From: Alastair D'Silva <redacted>

...

quoted

quoted

diff --git a/include/uapi/misc/ocxl.h b/include/uapi/misc/ocxl.h
index 4b0b0b756f3e..16e1f48ce280 100644
--- a/include/uapi/misc/ocxl.h
+++ b/include/uapi/misc/ocxl.h

@@ -32,6 +32,27 @@ struct ocxl_ioctl_attach {
        __u64 reserved3;
 };

+/*
+ * Version contains the version of the struct.
+ * Versions will always be backwards compatible, that is, new

versions will not
+ * alter existing fields
+ */
+struct ocxl_ioctl_get_metadata {

This sounds more like a function name, do we need it to be
_get_metdata?

It pretty much is a function, it returns to userspace metadata about
the descriptor being operated on.

It's not a function, it's a struct?

Outside of "management English" "get" is a verb, so using it in the name
of the struct is confusing, it should be a noun phrase.

cheers