Re: [PATCH] soc/fsl/guts: Add a NULL check for devm_kasprintf()

On Sun, Jan 7, 2018 at 9:06 PM, Y.b. Lu [off-list ref] wrote:

quoted

-----Original Message-----
From: Fabio Estevam [mailto:festevam@gmail.com]
Sent: 2018=E5=B9=B41=E6=9C=886=E6=97=A5 21:23
To: Leo Li <redacted>
Cc: linuxppc-dev@lists.ozlabs.org; Y.b. Lu <yangbo.lu@nxp.com>; Fabio
Estevam [off-list ref]
Subject: [PATCH] soc/fsl/guts: Add a NULL check for devm_kasprintf()

From: Fabio Estevam <redacted>

devm_kasprintf() may fail, so we should better add a NULL check and
propagate an error on failure.

Signed-off-by: Fabio Estevam <redacted>

[Y.b. Lu] It makes sense.
Acked-by: Yangbo Lu <yangbo.lu@nxp.com>

Merged.  Thanks.

quoted

---
 drivers/soc/fsl/guts.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c index

d89a6a8..82251b4 100644

--- a/drivers/soc/fsl/guts.c
+++ b/drivers/soc/fsl/guts.c

@@ -167,10 +167,16 @@ static int fsl_guts_probe(struct platform_device

*pdev)
      } else {
              soc_dev_attr.family =3D devm_kasprintf(dev, GFP_KERNEL, "Q=

orIQ");

quoted

      }
+     if (!soc_dev_attr.family)
+             return -ENOMEM;
      soc_dev_attr.soc_id =3D devm_kasprintf(dev, GFP_KERNEL,
                                           "svr:0x%08x", svr);
+     if (!soc_dev_attr.soc_id)
+             return -ENOMEM;
      soc_dev_attr.revision =3D devm_kasprintf(dev, GFP_KERNEL, "%d.%d",
                                             (svr >>  4) & 0xf, svr & 0x=

f);

quoted

+     if (!soc_dev_attr.revision)
+             return -ENOMEM;

      soc_dev =3D soc_device_register(&soc_dev_attr);
      if (IS_ERR(soc_dev))
--
2.7.4