Thread (6 messages) flat view 6 messages, 3 authors, 2018-01-08

Re: [RFC FIX v1 1/2] powerpc: Discover radix availability before scanning the memory nodes

From: Aneesh Kumar K.V <hidden>
Date: 2018-01-05 11:16:52


On 01/05/2018 04:35 PM, Bharata B Rao wrote:
quoted hunk ↗ jump to hunk
Currently device tree nodes for memory are scanned before the
radix feature is discovered in mmu_early_init_devtree(). Move this
routine ahead of scanning memory nodes so that we know if the
guest is radix or not when scanning ibm,dynamic-reconfiguration-memory.

Signed-off-by: Bharata B Rao <redacted>
---
  arch/powerpc/kernel/prom.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
index b15bae2..079d893 100644
--- a/arch/powerpc/kernel/prom.c
+++ b/arch/powerpc/kernel/prom.c
@@ -722,6 +722,8 @@ void __init early_init_devtree(void *params)
  	 */
  	of_scan_flat_dt(early_init_dt_scan_chosen_ppc, boot_command_line);

+	mmu_early_init_devtree();
+
  	/* Scan memory nodes and rebuild MEMBLOCKs */
  	of_scan_flat_dt(early_init_dt_scan_root, NULL);
  	of_scan_flat_dt(early_init_dt_scan_memory_ppc, NULL);
@@ -783,8 +785,6 @@ void __init early_init_devtree(void *params)
  	spinning_secondaries = boot_cpu_count - 1;
  #endif

-	mmu_early_init_devtree();
-
  #ifdef CONFIG_PPC_POWERNV
  	/* Scan and build the list of machine check recoverable ranges */
  	of_scan_flat_dt(early_init_dt_scan_recoverable_ranges, NULL);
I guess that will cause issues with pa-feature scanning. I don't think 
we finalize cpu features/mmu features that early.

-aneesh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help