Re: [PATCH] drivers/macintosh: Use true for boolean value
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2018-01-24 00:47:06
Also in:
lkml
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2018-01-24 00:47:06
Also in:
lkml
"Gustavo A. R. Silva" [off-list ref] writes:
Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <redacted> --- drivers/macintosh/windfarm_pm72.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
This seems to be common across all those drivers. Can you please send one patch to fix them all to use bool: $ git grep "started = " drivers/macintosh/ drivers/macintosh/therm_adt746x.c: int started = 0; drivers/macintosh/therm_adt746x.c: started = 1; drivers/macintosh/windfarm_pm112.c: slots_started = 1; drivers/macintosh/windfarm_pm112.c: started = 1; drivers/macintosh/windfarm_pm121.c: pm121_started = 1; drivers/macintosh/windfarm_pm72.c: started = 1; drivers/macintosh/windfarm_pm81.c: wf_smu_started = 1; drivers/macintosh/windfarm_pm91.c: wf_smu_started = 1; drivers/macintosh/windfarm_rm31.c: started = 1; cheers