Re: [PATCH v10 27/27] mm: display pkey in smaps if arch_pkeys_enabled() is true
From: Michal Hocko <mhocko@kernel.org>
Date: 2018-01-30 12:16:15
Also in:
linux-arch, linux-kselftest, linux-mm, lkml
On Thu 18-01-18 17:50:48, Ram Pai wrote: [...]
quoted hunk ↗ jump to hunk
@@ -851,9 +848,13 @@ static int show_smap(struct seq_file *m, void *v, int is_pid) (unsigned long)(mss->pss >> (10 + PSS_SHIFT))); if (!rollup_mode) { - arch_show_smap(m, vma); +#ifdef CONFIG_ARCH_HAS_PKEYS + if (arch_pkeys_enabled()) + seq_printf(m, "ProtectionKey: %8u\n", vma_pkey(vma)); +#endif show_smap_vma_flags(m, vma); } +
Why do you need to add ifdef here? The previous patch should make arch_pkeys_enabled == F when CONFIG_ARCH_HAS_PKEYS=n. Btw. could you merge those two patches into one. It is usually much easier to review a new helper function if it is added along with a user.
m_cache_vma(m, vma); return ret; } -- 1.7.1
-- Michal Hocko SUSE Labs