Re: [PATCH v1 05/15] ASoC: fsl_ssi: Clean up helper functions of trigger()
From: Nicolin Chen <nicoleotsuka@gmail.com>
Date: 2018-01-04 19:43:54
Also in:
alsa-devel, lkml
On Mon, Jan 01, 2018 at 10:59:30PM +0100, Maciej S. Szmigiero wrote:
quoted
+static void fsl_ssi_config_enable(struct fsl_ssi *ssi, bool tx)
quoted
+ srcr = vals[tx].srcr; + stcr = vals[tx].stcr; + sier = vals[tx].sier;Implicit assumption here that RX == 0, TX == 1, as in the 03 patch.
Could replace it with "bool dir" as well. Thanks for the review.