On Fri, Dec 29, 2017 at 03:12:25PM +0100, Geert Uytterhoeven wrote:

quoted

+check_addr(struct device *dev, dma_addr_t dma_addr, size_t size,
+               const char *caller)
+{
+       if (unlikely(dev && !dma_capable(dev, dma_addr, size))) {
+               if (*dev->dma_mask >= DMA_BIT_MASK(32)) {
+                       dev_err(dev,
+                               "%s: overflow %llx+%zu of device mask %llx\n",

Please use "%pad" to format dma_addr_t ...

quoted

+                               caller, (long long)dma_addr, size,

... and use &dma_addr.

quoted

+                               (long long)*dev->dma_mask);

This cast is not needed, as u64 is unsigned long long in kernelspace on
all architectures.

Thanks, fixed.