Thread (14 messages) flat view 14 messages, 4 authors, 2018-01-22

Re: [2/4] powerpc/64: do not trace irqs-off at interrupt return to soft-disabled context

From: Michael Ellerman <hidden>
Date: 2017-12-12 11:39:29

On Thu, 2017-11-16 at 16:00:50 UTC, Nicholas Piggin wrote:
When an interrupt is returning to a soft-disabled context (which can
happen for non-maskable interrupts or synchronous interrupts), it goes
through the motions of soft-disabling again, including calling
TRACE_DISABLE_INTS (i.e., trace_hardirqs_off()).

This is not necessary, because we must already be soft-disabled in the
interrupt context, it also may be causing crashes in the irq tracing
code to re-enter as an nmi. Replace it with a warning to ensure that
soft-interrupts are still disabled.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/acb1feab320e38588fccc568e37677

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help