RE: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception

-----Original Message-----
From: Joakim Tjernlund [mailto:Joakim.Tjernlund@infinera.com]
Sent: Tuesday, November 21, 2017 11:17 AM
To: Leo Li <redacted>; York Sun <redacted>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception
=20
On Wed, 2017-09-06 at 19:19 +0000, Leo Li wrote:

quoted

quoted

-----Original Message-----
From: York Sun
Sent: Wednesday, September 06, 2017 10:34 AM
To: Leo Li <redacted>
Cc: Joakim Tjernlund <redacted>; linuxppc-dev
linuxppc- dev [off-list ref]
Subject: Re: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception

On 09/05/2017 04:59 AM, Joakim Tjernlund wrote:

quoted

get_user() had it args reversed causing NIP to be NULL:ed instead
of fixing up the PCI access.

Note: This still hangs my P1020 Freescale CPU hard, but at least I
get a NIP now.

Signed-off-by: Joakim Tjernlund <redacted>
---
  arch/powerpc/sysdev/fsl_pci.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/sysdev/fsl_pci.c

b/arch/powerpc/sysdev/fsl_pci.c index 7c8b779c329a..9e64c12dff6a
100644

--- a/arch/powerpc/sysdev/fsl_pci.c
+++ b/arch/powerpc/sysdev/fsl_pci.c

@@ -996,7 +996,7 @@ int fsl_pci_mcheck_exception(struct pt_regs

*regs)

quoted

quoted

quoted

  	if (is_in_pci_mem_space(addr)) {
  		if (user_mode(regs)) {
  			pagefault_disable();
-			ret =3D get_user(regs->nip, &inst);
+			ret =3D get_user(inst, (__u32 __user *)regs->nip);
  			pagefault_enable();
  		} else {
  			ret =3D probe_kernel_address(regs->nip, inst);

Leo,

Can you take a look, or assign it to someone who is familiar with thi=

s

code?

quoted

Acked-by: Li Yang <redacted>

Regards,
Leo

=20
I think this is forgotten, cannot se it in Linus tree.

Hi Scott,

Could you help to review this patch and pick it up?  Thanks.

Regards,
Leo