Thread (5 messages) flat view 5 messages, 2 authors, 2017-12-06
STALE3172d

[PATCH 1/3] tty/serial/ucc_uart: Delete an error message for a failed memory allocation in ucc_uart_probe()

From: SF Markus Elfring <hidden>
Date: 2017-12-06 21:12:04
Also in: kernel-janitors, linux-serial, lkml
Subsystem: freescale quicc engine ucc uart driver, the rest, tty layer and serial drivers · Maintainers: Timur Tabi, Linus Torvalds, Greg Kroah-Hartman, Jiri Slaby

From: Markus Elfring <redacted>
Date: Wed, 6 Dec 2017 21:41:14 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>
---
 drivers/tty/serial/ucc_uart.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c
index 2b6376e6e5ad..48364f0eba72 100644
--- a/drivers/tty/serial/ucc_uart.c
+++ b/drivers/tty/serial/ucc_uart.c
@@ -1254,10 +1254,8 @@ static int ucc_uart_probe(struct platform_device *ofdev)
 	}
 
 	qe_port = kzalloc(sizeof(struct uart_qe_port), GFP_KERNEL);
-	if (!qe_port) {
-		dev_err(&ofdev->dev, "can't allocate QE port structure\n");
+	if (!qe_port)
 		return -ENOMEM;
-	}
 
 	/* Search for IRQ and mapbase */
 	ret = of_address_to_resource(np, 0, &res);
-- 
2.15.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help