Re: [PATCH] powerpc/powernv : Add support to enable sensor groups
From: Shilpasri G Bhat <hidden>
Date: 2017-11-29 07:01:49
Also in:
lkml
From: Shilpasri G Bhat <hidden>
Date: 2017-11-29 07:01:49
Also in:
lkml
Hi, On 11/28/2017 05:07 PM, Michael Ellerman wrote:
Shilpasri G Bhat [off-list ref] writes:quoted
Adds support to enable/disable a sensor group. This can be used to select the sensor groups that needs to be copied to main memory by OCC. Sensor groups like power, temperature, current, voltage, frequency, utilization can be enabled/disabled at runtime. Signed-off-by: Shilpasri G Bhat <redacted> --- The skiboot patch for the opal call is posted below: https://lists.ozlabs.org/pipermail/skiboot/2017-November/009713.htmlCan you remind me why we're doing this with a completely bespoke sysfs API, rather than using some generic sensors API?
Disabling/Enabling sensor groups is not supported in the current generic sensors API. And also we dont export all type of sensors in HWMON as not all of them are environment sensors (like performance).
And if we must do it that way, please add documentation for the sysfs file(s) in Documentation/ABI/.
Will do. Thanks and Regards, Shilpa
cheers