Re: [PATCH v9 00/51] powerpc, mm: Memory Protection Keys

On Tue, Nov 07, 2017 at 02:47:10PM -0800, Dave Hansen wrote:

On 11/07/2017 02:39 PM, Ram Pai wrote:

quoted

As per the current semantics of sys_pkey_free(); the way I understand it,
the calling thread is saying disassociate me from this key.

No.  It is saying: "this *process* no longer has any uses of this key,
it can be reused".

ok, in light of the corrected semantics, I see no bug in the implimentation.

On Mon, Nov 06, 2017 at 10:28:41PM +0100, Florian Weimer wrote:

...

The problem is a pkey_alloc/pthread_create/pkey_free/pkey_alloc
sequence.  The pthread_create call makes the new thread inherit the
access rights of the current thread, but then the key is deallocated.
Reallocation of the same key will have that thread retain its access
rights, which is IMHO not correct.

Again.. in light of the corrected semantics --
 the child thread or any thread should not free
a key without cleaning up. 
(a) disassociate the key from its address space
(b) reset the permission on the key across all the threads of the
process.

Because any such uncleaned bits can cause unexpected behavior if the 
same key gets reallocated on sys_pkey_alloc().


-- 
Ram Pai