Thread (16 messages) flat view 16 messages, 3 authors, 2017-10-19

Re: [PATCH v4 5/5] powerpc/mce: hookup memory_failure for UE errors

From: Balbir Singh <bsingharora@gmail.com>
Date: 2017-10-16 05:40:22

On Mon, Oct 16, 2017 at 4:38 PM, Michael Ellerman [off-list ref] wrote:
Balbir Singh [off-list ref] writes:
quoted
If we are in user space and hit a UE error, we now have the
basic infrastructure to walk the page tables and find out
the effective address that was accessed, since the DAR
is not valid.

We use a work_queue content to hookup the bad pfn, any
other context causes problems, since memory_failure itself
can call into schedule() via lru_drain_ bits.

We could probably poison the struct page to avoid a race
between detection and taking corrective action.

Signed-off-by: Balbir Singh <bsingharora@gmail.com>
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
---
 arch/powerpc/kernel/mce.c | 70 +++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 67 insertions(+), 3 deletions(-)
I'm not sure why this is in mce.c but the rest was in mce_power.c ?
The way the code is organized is that save_mce_event is implemented here
and called from mce_power.c. save_mce_event() does the processing
of the event.

Balbir Singh.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help