Re: [PATCH 10/13] timer: Remove expires and data arguments from DEFINE_TIMER

From
Arnd Bergmann <arnd@arndb.de>
Date
2017-10-05 08:59:12
Also in
linux-mips, linux-pm, linux-s390, linux-scsi, netdev
Reply to
Kees Cook, 2017-10-04
On Thu, Oct 5, 2017 at 1:27 AM, Kees Cook [off-list ref] wrote:
Drop the arguments from the macro and adjust all callers with the
following script:

  perl -pi -e 's/DEFINE_TIMER\((.*), 0, 0\);/DEFINE_TIMER($1);/g;' \
    $(git grep DEFINE_TIMER | cut -d: -f1 | sort -u | grep -v timer.h)

Signed-off-by: Kees Cook <redacted>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> # for m68k parts
I was slightly worried about this large-scale rework, since it might conflict
with new users of DEFINE_TIMER(), causing bisection problems.

However, a little research showed that we have only added two users
in the past five years, so this is not a real concern.

for arch/arm, drivers/char and overall:

Acked-by: Arnd Bergmann <arnd@arndb.de>
Thread (28 messages) 28 messages, 10 authors, last reply 2017-10-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help