Thread (2 messages) flat view 2 messages, 2 authors, 2017-10-08

Re: powerpc: Always initialize input array when calling epapr_hypercall()

From: Michael Ellerman <hidden>
Date: 2017-10-08 08:43:40
Also in: lkml

On Thu, 2017-09-28 at 13:33:39 UTC, Seth Forshee wrote:
Several callers to epapr_hypercall() pass an uninitialized stack
allocated array for the input arguments, presumably because they
have no input arguments. However this can produce errors like
this one

 arch/powerpc/include/asm/epapr_hcalls.h:470:42: error: 'in' may be used uninitialized in this function [-Werror=maybe-uninitialized]
  unsigned long register r3 asm("r3") = in[0];
                                        ~~^~~

Fix callers to this function to always zero-initialize the input
arguments array to prevent this.

Signed-off-by: Seth Forshee <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/186b8f1587c79c2fa04bfa392fdf08

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help