Re: [PATCH v9 06/12] mm: zero struct pages during initialization

On Tue 03-10-17 11:22:35, Pasha Tatashin wrote:

On 10/03/2017 09:08 AM, Michal Hocko wrote:

quoted

On Wed 20-09-17 16:17:08, Pavel Tatashin wrote:

quoted

Add struct page zeroing as a part of initialization of other fields in
__init_single_page().

This single thread performance collected on: Intel(R) Xeon(R) CPU E7-8895
v3 @ 2.60GHz with 1T of memory (268400646 pages in 8 nodes):

                         BASE            FIX
sparse_init     11.244671836s   0.007199623s
zone_sizes_init  4.879775891s   8.355182299s
                   --------------------------
Total           16.124447727s   8.362381922s

Hmm, this is confusing. This assumes that sparse_init doesn't zero pages
anymore, right? So these number depend on the last patch in the series?

Correct, without the last patch sparse_init time won't change.

THen this is just misleading.
-- 
Michal Hocko
SUSE Labs