On 26/09/17 11:44, Vaibhav Jain wrote:

Hi Christophe,

A minor nitpick

Christophe Lombard [off-list ref] writes:

quoted

+	for (dar = (addr & ~(page_size - 1)); dar < (addr + size); dar += page_size) {
+		if (dar < vma->vm_start || dar > vma->vm_end) {

Code comment in mm_types.h for vm_end says it "The first byte after our
end address within vm_mm". So this condition should be
(dar < vma->vm_start || dar >= vma->vm_end)

Hmm, I *think* you're right... a quick grep through the tree seems to 
indicate that I'm not the only one to have made that mistake...

Christophe if you're happy to do a v3 with this fixed as well that would 
be great.

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited