Thread (9 messages) flat view 9 messages, 2 authors, 2017-09-13

Re: [PATCH v2 3/5] powerpc/mce: Hookup derror (load/store) UE errors

From: Nicholas Piggin <npiggin@gmail.com>
Date: 2017-09-13 06:21:32

On Wed, 13 Sep 2017 16:10:47 +1000
Balbir Singh [off-list ref] wrote:
Extract physical_address for UE errors by walking the page
tables for the mm and address at the NIP, to extract the
instruction. Then use the instruction to find the effective
address via analyse_instr().

We might have page table walking races, but we expect them to
be rare, the physical address extraction is best effort. The idea
is to then hook up this infrastructure to memory failure eventually.
This all looks pretty good to me, you can probably update these
changelogs now because you are hooking it into memory failure.

I wonder if it would be worth skipping the instruction analysis and
page table walk if we've recursed up to the maximum MCE depth, just
in case we're hitting MCEs in part of that code or data.

Thanks,
Nick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help