Re: [PATCH V13 2/4] powerpc/vphn: Improve recognition of PRRN/VPHN
From: Nathan Fontenot <hidden>
Date: 2017-09-06 14:24:33
Also in:
lkml
On 09/01/2017 10:48 AM, Michael Bringmann wrote:
quoted hunk ↗ jump to hunk
powerpc/vphn: On Power systems with shared configurations of CPUs and memory, there are some issues with the association of additional CPUs and memory to nodes when hot-adding resources. This patch updates the initialization checks to independently recognize PRRN or VPHN support. Signed-off-by: Michael Bringmann <redacted> --- Changes in V13: -- Split patch to improve review --- arch/powerpc/mm/numa.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index 312f6ee..c08d736 100644 --- a/arch/powerpc/mm/numa.c +++ b/arch/powerpc/mm/numa.c@@ -1543,7 +1543,8 @@ int start_topology_update(void) rc = of_reconfig_notifier_register(&dt_update_nb); #endif } - } else if (firmware_has_feature(FW_FEATURE_VPHN) && + } + if (firmware_has_feature(FW_FEATURE_VPHN) && lppaca_shared_proc(get_lppaca())) { if (!vphn_enabled) { vphn_enabled = 1;
In patch 1/4, you removed the setting of prrn_enabled and vphn_enabled to 0. It seems like that update would be part of this patch. -Nathan
quoted hunk ↗ jump to hunk
@@ -1568,7 +1569,8 @@ int stop_topology_update(void) #ifdef CONFIG_SMP rc = of_reconfig_notifier_unregister(&dt_update_nb); #endif - } else if (vphn_enabled) { + } + if (vphn_enabled) { vphn_enabled = 0;> rc = del_timer_sync(&topology_timer); }