Re: [RFC Part1 PATCH v3 16/17] X86/KVM: Provide support to create Guest and HV shared per-CPU variables

On 9/4/17 12:05 PM, Borislav Petkov wrote:

On Fri, Sep 01, 2017 at 05:52:13PM -0500, Brijesh Singh wrote:

quoted

 So far, we have not seen the need for having such functions except
this cases. The approach we have right now works just fine and not
sure if its worth adding new functions.

Then put the call to kvm_map_hv_shared_decrypted() into
kvm_smp_prepare_boot_cpu() to denote that you're executing this whole
stuff only once during guest init.

Now you're doing additional jumping-through-hoops with that once static
var just so you can force something which needs to execute only once but
gets called in a per-CPU path.

See what I mean?

Yes, I see your point. I will address this issue in next rev.


-Brijesh