Re: powerpc/macintosh: constify wf_sensor_ops structures
From: Michael Ellerman <hidden>
Date: 2017-09-01 13:31:19
Also in:
kernel-janitors, lkml
On Wed, 2017-08-02 at 21:01:45 UTC, Julia Lawall wrote:
The wf_sensor_ops structures are only stored in the ops field of a
wf_sensor structure, which is declared as const. Thus the
wf_sensor_ops structures themselves can be const.
Done with the help of Coccinelle.
// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct wf_sensor_ops i@p = { ... };
@ok1@
identifier r.i;
struct wf_sensor s;
position p;
@@
s.ops = &i@p
@ok2@
identifier r.i;
struct wf_sat_sensor s;
position p;
@@
s.sens.ops = &i@p
@bad@
position p != {r.p,ok1.p,ok2.p};
identifier r.i;
struct wf_sensor_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct wf_sensor_ops i = { ... };
// </smpl>
Signed-off-by: Julia Lawall <redacted>Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/de854e54d79bc0ad5c45c5be50821b cheers