Thread (10 messages) flat view 10 messages, 4 authors, 2017-09-01

Re: [PATCH] powerpc/pseries: Don't attempt to acquire drc during memory hot add for assigned lmbs

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2017-08-31 10:24:30

Nathan Fontenot [off-list ref] writes:
...
Hopefully that helps clarify things.
Yep thanks. In short, read the code better Michael :)

I folded in this hunk, which will keep the compiler happy and is also
correct I believe. Basically in the success case (lmbs_added == lmbs_to_add)
we explicitly set rc to 0.
@@ -870,6 +873,7 @@ static int dlpar_memory_add_by_count(u32 lmbs_to_add, struct property *prop)
                                lmbs[i].base_addr, lmbs[i].drc_index);
                        lmbs[i].reserved = 0;
                }
+               rc = 0;
        }
 
        return rc;
cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help