Thread (20 messages) flat view 20 messages, 5 authors, 2017-08-22

Re: [PATCH 0/2] Allow scsi_prep_fn to occur for retried commands

From: Abdul Haleem <hidden>
Date: 2017-08-22 06:42:19
Also in: linux-next, linux-scsi, lkml

On Mon, 2017-08-21 at 17:11 -0500, Brian King wrote:
The following two patches address the hang issue being observed
with Bart's patch on powerpc. The first patch moves the initialization
of jiffies_at_alloc from scsi_init_command to scsi_init_rq, and ensures
we don't zero jiffies_at_alloc in scsi_init_command. The second patch
saves / restores the retry counter in scsi_init_command which lets us
go through scsi_init_command for retries and not forget why we were
there. 

These patches have only been boot tested on my Power machine with ipr
to ensure they fix the issue I was seeing.

-Brian
Thank you Brian and Bart, for your efforts to fix this bug.

I tested these patches on my PowerPC machine and system booted fine.

[PATCHv2 1/2] scsi: Move scsi_cmd->jiffies_at_alloc initialization to
allocation time
[PATCH 2/2] scsi: Preserve retry counter through scsi_prep_fn

Reported-and-Tested-by: Abdul Haleem <redacted>

-- 
Regard's

Abdul Haleem
IBM Linux Technology Centre
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help