Re: [PATCH 5/5] Use __func__ instead of function name
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2017-08-18 11:25:43
Also in:
lkml
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2017-08-18 11:25:43
Also in:
lkml
Michal Such=C3=A1nek [off-list ref] writes:
On 2017-07-29 09:24, SZ Lin wrote:quoted
Fix following checkpatch.pl warning: WARNING: Prefer using '"%s...", __func__' to using the function's name, in a string =20 Signed-off-by: SZ Lin <redacted> --- drivers/char/tpm/tpm_ibmvtpm.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) =20diff --git a/drivers/char/tpm/tpm_ibmvtpm.c=20b/drivers/char/tpm/tpm_ibmvtpm.c index e75a674b44ac..2d33acc43e25 100644--- a/drivers/char/tpm/tpm_ibmvtpm.c +++ b/drivers/char/tpm/tpm_ibmvtpm.c@@ -151,7 +151,7 @@ static int tpm_ibmvtpm_send(struct tpm_chip *chip,u8 *buf, size_t count) rc =3D ibmvtpm_send_crq(ibmvtpm->vdev, be64_to_cpu(word[0]), be64_to_cpu(word[1])); if (rc !=3D H_SUCCESS) { - dev_err(ibmvtpm->dev, "tpm_ibmvtpm_send failed rc=3D%d\n", rc); + dev_err(ibmvtpm->dev, "%s failed rc=3D%d\n", __func__, rc);Can function name contain a %?
Let's hope not. $ git grep "%s.*__func__" | wc -l 16937 cheers