On Tue 8/8/2017 6:05 PM, Michael Ellerman [off-list ref] wrote:

-----Original Message-----
From: Michael Ellerman [mailto:mpe@ellerman.id.au]
Sent: Tuesday, August 08, 2017 6:05 PM
To: Qiang Zhao <qiang.zhao@nxp.com>; tglx@linutronix.de
Cc: oss@buserror.net; linuxppc-dev@lists.ozlabs.org; Xiaobo Xie
[off-list ref]; linux-kernel@vger.kernel.org
Subject: RE: [PATCH v10 4/4] irqchip/qeic: remove PPCisms for QEIC
=20
Qiang Zhao [off-list ref] writes:
=20

quoted

On Mon 8/7/2017 3:02 PM, Michael Ellerman [off-list ref] wrote:

quoted

-----Original Message-----
From: Michael Ellerman [mailto:mpe@ellerman.id.au]
Sent: Monday, August 07, 2017 3:02 PM
To: Qiang Zhao <qiang.zhao@nxp.com>; tglx@linutronix.de
Cc: oss@buserror.net; Qiang Zhao <qiang.zhao@nxp.com>; linuxppc-
dev@lists.ozlabs.org; Xiaobo Xie [off-list ref]; linux-
kernel@vger.kernel.org
Subject: Re: [PATCH v10 4/4] irqchip/qeic: remove PPCisms for QEIC

Zhao Qiang [off-list ref] writes:

quoted

QEIC was supported on PowerPC, and dependent on PPC, Now it is
supported on other platforms, so remove PPCisms.

Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
 arch/powerpc/platforms/83xx/km83xx.c          |   1 -
 arch/powerpc/platforms/83xx/misc.c            |   1 -
 arch/powerpc/platforms/83xx/mpc832x_mds.c     |   1 -
 arch/powerpc/platforms/83xx/mpc832x_rdb.c     |   1 -
 arch/powerpc/platforms/83xx/mpc836x_mds.c     |   1 -
 arch/powerpc/platforms/83xx/mpc836x_rdk.c     |   1 -
 arch/powerpc/platforms/85xx/corenet_generic.c |   1 -
 arch/powerpc/platforms/85xx/mpc85xx_mds.c     |   1 -
 arch/powerpc/platforms/85xx/mpc85xx_rdb.c     |   1 -
 arch/powerpc/platforms/85xx/twr_p102x.c       |   1 -
 drivers/irqchip/irq-qeic.c                    | 188 +++++++++++----=

-----------

quoted

quoted

quoted

 include/soc/fsl/qe/qe_ic.h                    | 132 ---------------=

---

quoted

quoted

quoted

 12 files changed, 80 insertions(+), 250 deletions(-)  delete mode
100644 include/soc/fsl/qe/qe_ic.h

diff --git a/arch/powerpc/platforms/83xx/km83xx.c

b/arch/powerpc/platforms/83xx/km83xx.c
index d8642a4..b1cef0a 100644

--- a/arch/powerpc/platforms/83xx/km83xx.c
+++ b/arch/powerpc/platforms/83xx/km83xx.c

@@ -38,7 +38,6 @@
 #include <sysdev/fsl_soc.h>
 #include <sysdev/fsl_pci.h>
 #include <soc/fsl/qe/qe.h>
-#include <soc/fsl/qe/qe_ic.h>

You deleted that file in patch 2. So didn't you just break the build
for the last two commits?

Sorry, I am not sure what you said. Could you explain?

=20
Don't worry about it. I was confused by the fact that we have both:
=20
  drivers/soc/fsl/qe/qe_ic.h
=20
and:
=20
  include/soc/fsl/qe/qe_ic.h
=20
cheers

I think this is a issue left over by history.
In patch with commit id 7aa1aa6ecec2af19d9aa85430ce3e56119e21626, I just mo=
ve them out from arch/powerpc. =20
Maybe need to ask the original author why there are 2 qe_ic.h.

Best Regards
Qiang Zhao