Re: [PATCH 4/4] axonram: Delete an unnecessary variable initialisation in axon_ram_probe()
From: Tyrel Datwyler <hidden>
Date: 2017-08-04 16:51:24
Also in:
kernel-janitors, lkml
On 08/03/2017 12:17 PM, SF Markus Elfring wrote:
quoted hunk ↗ jump to hunk
From: Markus Elfring <redacted> Date: Thu, 3 Aug 2017 20:34:00 +0200 The local variable "rc" will eventually be set only to an error code. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring <redacted> --- arch/powerpc/sysdev/axonram.c | 1 - 1 file changed, 1 deletion(-)diff --git a/arch/powerpc/sysdev/axonram.c b/arch/powerpc/sysdev/axonram.c index 93cc902350db..5677f3371e30 100644 --- a/arch/powerpc/sysdev/axonram.c +++ b/arch/powerpc/sysdev/axonram.c@@ -184,7 +184,6 @@ static int axon_ram_probe(struct platform_device *device) static int axon_ram_bank_id = -1; struct axon_ram_bank *bank; struct resource resource; - int rc = 0;
You've completely removed the decleration of "rc" instead of removing the "= 0" initialization. I would expect a compilation test to have turned up an undeclared use error for "rc". -Tyrel
axon_ram_bank_id++;