Thread (44 messages) 44 messages, 4 authors, 2018-11-07

Re: [PATCH 02/24] powerpc/mm: Pre-filter SRR1 bits before do_page_fault()

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2017-07-24 13:48:59

LEROY Christophe [off-list ref] writes:
Benjamin Herrenschmidt [off-list ref] a =C3=A9crit=C2=A0:
quoted
diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c
index faddc87d0205..f04bc9f6b134 100644
--- a/arch/powerpc/mm/fault.c
+++ b/arch/powerpc/mm/fault.c
@@ -203,23 +203,13 @@ static int __do_page_fault(struct pt_regs=20=20
*regs, unsigned long address,
 	unsigned int flags =3D FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE;
 	int code =3D SEGV_MAPERR;
 	int is_write =3D 0;
-	int trap =3D TRAP(regs);
- 	int is_exec =3D trap =3D=3D 0x400;
+ 	int is_exec =3D TRAP(regs) =3D=3D 0x400;
Don't we have a tab/space issue here ?
We do:

  Warnings for commit 0f9b89d759ba 'powerpc/mm: Pre-filter SRR1 bits before=
 do_page_fault()'
    Lines beginning with space in arch/powerpc/mm/fault.c
      + 	int is_exec =3D TRAP(regs) =3D=3D 0x400;

I can fix it up.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help