Re: [PATCH 3/4] powerpc/mm/radix: Avoid flushing the PWC on every flush_tlb_range

Hi Benjamin,

[auto build test ERROR on powerpc/next]
[also build test ERROR on v4.13-rc1 next-20170717]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Benjamin-Herrenschmidt/powerpc-mm-radix-Don-t-iterate-all-sets-when-flushing-the-PWC/20170715-044140
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-pasemi_defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=powerpc 

All error/warnings (new ones prefixed by >>):

   In file included from include/asm-generic/bug.h:4:0,
                    from arch/powerpc/include/asm/bug.h:127,
                    from include/linux/bug.h:4,
                    from include/linux/mmdebug.h:4,
                    from include/linux/mm.h:8,
                    from arch/powerpc/mm/tlb-radix.c:12:
   arch/powerpc/mm/tlb-radix.c: In function 'radix__flush_tlb_collapsed_pmd':

quoted

include/linux/compiler.h:529:38: error: call to '__compiletime_assert_378' declared with attribute error: BUILD_BUG failed

     _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
                                         ^
   include/linux/compiler.h:512:4: note: in definition of macro '__compiletime_assert'
       prefix ## suffix();    \
       ^~~~~~
   include/linux/compiler.h:529:2: note: in expansion of macro '_compiletime_assert'
     _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
     ^~~~~~~~~~~~~~~~~~~
   include/linux/bug.h:54:37: note: in expansion of macro 'compiletime_assert'
    #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
                                        ^~~~~~~~~~~~~~~~~~
   include/linux/bug.h:88:21: note: in expansion of macro 'BUILD_BUG_ON_MSG'
    #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed")
                        ^~~~~~~~~~~~~~~~

quoted

include/linux/huge_mm.h:218:27: note: in expansion of macro 'BUILD_BUG'

    #define HPAGE_PMD_SIZE ({ BUILD_BUG(); 0; })
                              ^~~~~~~~~

quoted

arch/powerpc/mm/tlb-radix.c:378:15: note: in expansion of macro 'HPAGE_PMD_SIZE'

     end = addr + HPAGE_PMD_SIZE;
                  ^~~~~~~~~~~~~~

vim +/HPAGE_PMD_SIZE +378 arch/powerpc/mm/tlb-radix.c

   353	
   354	void radix__flush_tlb_collapsed_pmd(struct mm_struct *mm, unsigned long addr)
   355	{
   356		int local = mm_is_thread_local(mm);
   357		unsigned long ap = mmu_get_ap(mmu_virtual_psize);
   358		unsigned long pid, end;
   359	
   360	
   361		pid = mm ? mm->context.id : 0;
   362		if (unlikely(pid == MMU_NO_CONTEXT))
   363			goto no_context;
   364	
   365		/* 4k page size, just blow the world */
   366		if (PAGE_SIZE == 0x1000) {
   367			radix__flush_all_mm(mm);
   368			return;
   369		}
   370	
   371		/* Otherwise first do the PWC */
   372		if (local)
   373			_tlbiel_pid(pid, RIC_FLUSH_PWC);
   374		else
   375			_tlbie_pid(pid, RIC_FLUSH_PWC);
   376	
   377		/* Then iterate the pages */
 > 378		end = addr + HPAGE_PMD_SIZE;
   379		for (; addr < end; addr += PAGE_SIZE) {
   380			if (local)
   381				_tlbiel_va(addr, pid, ap, RIC_FLUSH_TLB);
   382			else
   383				_tlbie_va(addr, pid, ap, RIC_FLUSH_TLB);
   384		}
   385	no_context:
   386		preempt_enable();
   387	}
   388	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation