Thread (18 messages) flat view 18 messages, 5 authors, 2017-07-14

Re: [PATCH 1/5] powerpc/lib/sstep: Add cmpb instruction emulation

From: Andrew Donnellan <hidden>
Date: 2017-07-13 03:52:54

On 13/07/17 13:25, Matt Brown wrote:
quoted hunk ↗ jump to hunk
@@ -1049,6 +1066,13 @@ int analyse_instr(struct instruction_op *op, struct pt_regs *regs,
 			do_cmp_unsigned(regs, val, val2, rd >> 2);
 			goto instr_done;

+		case 19173952: /* cmpb */
This looks wrong and should never trigger, given that the switch 
statement is comparing against ((instr >> 1) & 0x3ff).

How did you get this value?

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help