Re: [PATCH 1/4] powerpc/powernv: handle the platform error reboot in ppc_md.restart
From: Nicholas Piggin <npiggin@gmail.com>
Date: 2017-07-11 17:09:52
On Mon, 10 Jul 2017 11:18:35 +0530 Mahesh Jagannath Salgaonkar [off-list ref] wrote:
On 07/06/2017 11:26 PM, Nicholas Piggin wrote:quoted
On Wed, 5 Jul 2017 14:04:19 +1000 Nicholas Piggin [off-list ref] wrote:
quoted
+ /* + * We reached here. There can be three possibilities: + * 1. We are running on a firmware level that do not support + * opal_cec_reboot2() + * 2. We are running on a firmware level that do not support + * OPAL_REBOOT_PLATFORM_ERROR reboot type. + * 3. We are running on FSP based system that does not need + * opal to trigger checkstop explicitly for error analysis. + * The FSP PRD component would have already got notified + * about this error through other channels. + */ +Not sure if looping forever unconditionally here is better idea. How about we check panic_timeout and decide whether to reboot or fall through for loop ? if (panic_timeout != 0) emergency_restart();quoted
+ for (;;) + ;> +}
Yes that's a good point. What I've done is just to call ppc_md.restart(). To match BMC behaviour, particularly for point #3, I think we expect a restart here. MCE is not quite the same thing as panic, so I think that's okay to ignore the panic timeout. The important thing is the MCE messages will have been sent to Linux console. Thanks, Nick