Thread (4 messages) 4 messages, 4 authors, 2017-08-03

Re: [PATCH 1/3] PCI: dwc: Handle host_init failures

From: "Jingoo Han" <jingoohan1@gmail.com>
Date: 2017-07-17 19:28:19
Also in: linux-arm-kernel, linux-arm-msm, linux-omap, linux-pci, linux-samsung-soc, lkml

On Monday, July 17, 2017 7:18 AM, Joao Pinto wrote:
=20
Hi Bjorn Andersson,
=20
=C3=80s 7:39 AM de 7/16/2017, Bjorn Andersson escreveu:
quoted
In several dwc based drivers host_init can fail, so make sure to
propagate and handle this to avoid continuing operation of a driver =
or
quoted
hardware in an invalid state.

Signed-off-by: Bjorn Andersson <redacted>
---
 drivers/pci/dwc/pci-dra7xx.c           |  4 +++-
 drivers/pci/dwc/pci-exynos.c           |  4 +++-
 drivers/pci/dwc/pci-imx6.c             |  4 +++-
 drivers/pci/dwc/pci-keystone.c         |  4 +++-
 drivers/pci/dwc/pci-layerscape.c       | 14 ++++++++++----
 drivers/pci/dwc/pcie-armada8k.c        |  4 +++-
 drivers/pci/dwc/pcie-artpec6.c         |  4 +++-
 drivers/pci/dwc/pcie-designware-host.c |  7 +++++--
 drivers/pci/dwc/pcie-designware-plat.c |  4 +++-
 drivers/pci/dwc/pcie-designware.h      |  2 +-
 drivers/pci/dwc/pcie-kirin.c           |  4 +++-
 drivers/pci/dwc/pcie-qcom.c            |  6 ++++--
 drivers/pci/dwc/pcie-spear13xx.c       |  4 +++-
 13 files changed, 47 insertions(+), 18 deletions(-)
[.....]
=20
A step in the right direction :). In the future we should add host =
init
validation in the specific SoC drivers, like Layerscape and Qcom have, =
to
assure
that any problem is treated properly in the core driver.
I agree with your opinion.
=20
Acked-by: Joao Pinto <redacted>
Acked-by: Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help