Re: [PATCH 1/5] powernv:idle: Move device-tree parsing to one place.

On Fri, 7 Jul 2017 16:55:39 +0530
Gautham R Shenoy [off-list ref] wrote:

Hello Nicholas,

On Fri, Jul 07, 2017 at 12:53:40AM +1000, Nicholas Piggin wrote:

quoted

I wouldn't have the wrapper function... but it's your code so it's
up to you. One thing though is that this function you have called get_
just to return the pointer, but it does not take a reference or
allocate memory or initialize the structure. Other functions with the
same prefix do such things. Can we make something more consistent?  

I agree with the wrapper function. But then the alternative was to
declare this variable as an extern so that cpuidle can access it. Is
that preferable ?

Yeah I think that's fine.

[snip

quoted

[snip]

There's a lot of code movement, I haven't reviewed it all carefully, but
it looks good in general. I'll apply the patches and check the result
in the next few days when I get a bit of time.  

If it helps, I will post the subsequent version breaking this patch
into smaller ones.

If you could without too much trouble, that would be a good help.

Thanks,
Nick