Re: [PATCH] powerpc/mm: Implemented default_hugepagesz verification for powerpc
From: Anshuman Khandual <hidden>
Date: 2017-07-05 04:31:46
Also in:
lkml
On 07/04/2017 01:35 AM, Victor Aoqui wrote:
quoted hunk ↗ jump to hunk
Implemented default hugepage size verification (default_hugepagesz=) in order to allow allocation of defined number of pages (hugepages=) only for supported hugepage sizes. Signed-off-by: Victor Aoqui <redacted> --- arch/powerpc/mm/hugetlbpage.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c index a4f33de..464e72e 100644 --- a/arch/powerpc/mm/hugetlbpage.c +++ b/arch/powerpc/mm/hugetlbpage.c@@ -797,6 +797,21 @@ static int __init hugepage_setup_sz(char *str) } __setup("hugepagesz=", hugepage_setup_sz); +static int __init default_hugepage_setup_sz(char *str)
The function name should be hugetlb_default_size_setup in sync with the generic function hugetlb_default_setup for the same parameter default_hugepagesz.
+{
+ unsigned long long size;
+
+ size = memparse(str, &str);
+
+ if (add_huge_page_size(size) != 0) {I am little bit confused here. Do we always follow another 'hugepages=' element after 'default_hugepagesz' ? If not, then we dont have to do 'add_huge_page_size'. But then that function checks for valid huge page sizes and skips adding hstate if its already added. So I guess it okay.
+ hugetlb_bad_size();
+ pr_err("Invalid default huge page size specified(%llu)\n", size);Error message should have 'ppc' some where to indicate that the arch rejected the size not core MM.