Thread (13 messages) 13 messages, 5 authors, 2017-06-19

Re: [v2, 2/4] powerpc/ftrace: Pass the correct stack pointer for DYNAMIC_FTRACE_WITH_REGS

From: Michael Ellerman <hidden>
Date: 2017-06-19 12:22:41

On Thu, 2017-06-01 at 10:48:16 UTC, "Naveen N. Rao" wrote:
For DYNAMIC_FTRACE_WITH_REGS, we should be passing-in the original set
of registers in pt_regs, to capture the state _before_ ftrace_caller.
However, we are instead passing the stack pointer *after* allocating a
stack frame in ftrace_caller. Fix this by saving the proper value of r1
in pt_regs. Also, use SAVE_10GPRS() to simplify the code.

Fixes: 153086644fd1f ("powerpc/ftrace: Add support for -mprofile-kernel
ftrace ABI")
Signed-off-by: Naveen N. Rao <redacted>
Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/a4979a7e71eb8da976cbe4a0a1fa50

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help