Thread (41 messages) flat view 41 messages, 5 authors, 2017-06-14

Re: [PATCH 13/14] powerpc/64: runlatch CTRL[RUN] set optimisation

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2017-06-14 03:34:28

Benjamin Herrenschmidt [off-list ref] writes:
On Tue, 2017-06-13 at 20:04 +1000, Michael Ellerman wrote:
quoted
quoted
Good idea.=C2=A0 Writing to CTRL register can change only the RUN fiel=
d.
quoted
quoted
Was this any different in older generations?
=20
No AFAICS back to 2.02.
=20
quoted
Anton and Ben kept the mfspr/mtspr part in earlier updates to this
routine.
=20
Doing the read/modify write is forward compatible vs a new writable
field, whereas writing the whole register with a known value is not.
At this stage I wouldn't worry too much about it. What we can do is
write a pre-cooked value (from reading it earlier once at boot) if we
are paranoid or just do what Nick does and put the onus on future
designs that might want to re-use it for other things to add a mode
bits to configure the new feature in.
Fine by me.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help