Re: [PATCH] cxl: Fix error path on bad ioctl
From: Vaibhav Jain <hidden>
Date: 2017-06-02 16:32:34
Hi Fred, Good catch. Frederic Barrat [off-list ref] writes:
quoted hunk ↗ jump to hunk
Fix error path if we can't copy user structure on CXL_IOCTL_START_WORK ioctl. Signed-off-by: Frederic Barrat <redacted> Cc: stable@vger.kernel.org --- drivers/misc/cxl/file.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)diff --git a/drivers/misc/cxl/file.c b/drivers/misc/cxl/file.c index 17b433f1ce23..caa44adfa60e 100644 --- a/drivers/misc/cxl/file.c +++ b/drivers/misc/cxl/file.c@@ -160,10 +160,8 @@ static long afu_ioctl_start_work(struct cxl_context *ctx, /* Do this outside the status_mutex to avoid a circular dependency with * the locking in cxl_mmap_fault() */ if (copy_from_user(&work, uwork, - sizeof(struct cxl_ioctl_start_work))) { - rc = -EFAULT; - goto out; - } + sizeof(struct cxl_ioctl_start_work)))
Bike-shedding a bit, but s/sizeof(struct cxl_ioctl_start_work)))/sizeof(work)/ would look much cleaner Reviewed-by: Vaibhav Jain <redacted>