Thread (1 message) 1 message, 1 author, 2017-06-02

Re: powerpc/opal-irqchip: Use interrupt names if present

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2017-06-02 14:11:42
Also in: linux-devicetree

On Fri, 2017-06-02 at 14:39 +0200, Geert Uytterhoeven wrote:
quoted
diff --git a/arch/powerpc/platforms/powernv/opal-irqchip.c b/arch/powerpc/platforms/powernv/opal-irqchip.c
index 998316bf2dad..ecdcba9d1220 100644
--- a/arch/powerpc/platforms/powernv/opal-irqchip.c
+++ b/arch/powerpc/platforms/powernv/opal-irqchip.c
@@ -183,8 +183,9 @@ void opal_event_shutdown(void)
+       /* It's not an error for the names to be missing */
+       of_property_read_string_array(opal_node, "opal-interrupts-names",
+                                     names, opal_irq_count);
Just double-checking, as it's different from the standard "interrupt-names":
is "opal-interrupts-names" the correct name?
Yes, because the property it refers to isn't a standard "interrupts"
property... it's ... complicated :-)

It could have been mind you, but the decision for that was made years
ago... it's a bunch of interrupts OPAL is interested in, which Linux
requests and sets up a handler for which just calls back into OPAL. 

In any case, firmwares with that property are out now.

Cheers,
Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help