RE: [PATCH] soc/qman: Sleep instead of stuck hacking jiffies.
From: David Laight <hidden>
Date: 2017-06-26 15:54:42
Also in:
linux-arm-kernel, lkml
From: Karim Eshapa
Sent: 25 June 2017 16:14 Use msleep() instead of stucking with long delay will be more efficient.
...
quoted hunk ↗ jump to hunk
--- a/drivers/soc/fsl/qbman/qman.c +++ b/drivers/soc/fsl/qbman/qman.c@@ -1084,11 +1084,7 @@ static int drain_mr_fqrni(struct qm_portal *p) * entries well before the ring has been fully consumed, so * we're being *really* paranoid here. */ - u64 now, then =3D jiffies; - - do { - now =3D jiffies; - } while ((then + 10000) > now); + msleep(1);
... How is that in any way equivalent? If HZ is 1000 the old code loops for 10 seconds. If HZ is 250 (common for some distros) it loops for 40 seconds. Clearly both are horrid, but it isn't at all clear that a 1ms sleep is performing the same job. My guess is that this code is never called, and broken if actually called. David