Re: [PATCH] cxl: Unlock on error in probe

On 05/05/17 17:37, Dan Carpenter wrote:

On Fri, May 05, 2017 at 05:14:15PM +1000, Andrew Donnellan wrote:

quoted

sem is a global and it looks like it's intended to be held after
device_open() returns and only released in device_close(), so this looks
wrong.

This doesn't affect the success path, it only means that if
device_open() fails because we don't have enough free memory or whatever
then we can try again later.

Argh, I completely missed the "return 0" above err1 and thought the 
success path fell through. My mistake, that's what I get for trying to 
review patches after staring at hardware simulation logs all day...

In that case, the patch looks fine to me.

Reviewed-by: Andrew Donnellan <redacted>

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited