Thread (1 message) 1 message, 1 author, 2017-05-04

Re: [PATCH 1/8] powerpc/kprobes: Pause function_graph tracing during jprobes handling

From: Naveen N. Rao <hidden>
Date: 2017-05-04 04:36:04

[Copying linuxppc-dev list which I missed cc'ing initially]

On 2017/05/03 03:58PM, Steven Rostedt wrote:
On Wed,  3 May 2017 23:43:41 +0530
"Naveen N. Rao" [off-list ref] wrote:
quoted
This fixes a crash when function_graph and jprobes are used together.
This is essentially commit 237d28db036e ("ftrace/jprobes/x86: Fix
conflict between jprobes and function graph tracing"), but for powerpc.

Jprobes breaks function_graph tracing since the jprobe hook needs to use
jprobe_return(), which never returns back to the hook, but instead to
the original jprobe'd function. The solution is to momentarily pause
function_graph tracing before invoking the jprobe hook and re-enable it
when returning back to the original jprobe'd function.
I wonder if any of this code could be made arch agnostic?
I don't see a way to do that as the jprobe handlers are all 
arch-specific.
Anyway, Acked-by: Steven Rostedt (VMware) [off-list ref]
Thanks,
- Naveen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help