Re: [PATCH net] bnx2x: Align RX buffers
From: David Miller <davem@davemloft.net>
Date: 2017-05-01 02:51:10
Also in:
netdev
From: David Miller <davem@davemloft.net>
Date: 2017-05-01 02:51:10
Also in:
netdev
From: Scott Wood <redacted> Date: Fri, 28 Apr 2017 19:17:41 -0500
The bnx2x driver is not providing proper alignment on the receive buffers it passes to build_skb(), causing skb_shared_info to be misaligned. skb_shared_info contains an atomic, and while PPC normally supports unaligned accesses, it does not support unaligned atomics. Aligning the size of rx buffers will ensure that page_frag_alloc() returns aligned addresses. This can be reproduced on PPC by setting the network MTU to 1450 (or other non-multiple-of-4) and then generating sufficient inbound network traffic (one or two large "wget"s usually does it), producing the following oops:
...
Fixes: d46d132cc021 ("bnx2x: use netdev_alloc_frag()")
Signed-off-by: Scott Wood <redacted>Applied, thanks.