Re: [PATCH 4/9] powerpc/mm: Reshuffle vmemmap_free()
From: Stephen Rothwell <hidden>
Date: 2017-04-12 00:33:28
Also in:
nvdimm
From: Stephen Rothwell <hidden>
Date: 2017-04-12 00:33:28
Also in:
nvdimm
Hi Oliver, On Wed, 12 Apr 2017 03:42:28 +1000 Oliver O'Halloran [off-list ref] wrote:
diff --git a/arch/powerpc/mm/init_64.c b/arch/powerpc/mm/init_64.c index ec84b31c6c86..f8124edb6ffa 100644 --- a/arch/powerpc/mm/init_64.c +++ b/arch/powerpc/mm/init_64.c@@ -234,12 +234,15 @@ static unsigned long vmemmap_list_free(unsigned long start) void __ref vmemmap_free(unsigned long start, unsigned long end) { unsigned long page_size = 1 << mmu_psize_defs[mmu_vmemmap_psize].shift; + unsigned long page_order = get_order(page_size); start = _ALIGN_DOWN(start, page_size); pr_debug("vmemmap_free %lx...%lx\n", start, end); for (; start < end; start += page_size) { + struct page *page = pfn_to_page(addr >> PAGE_SHIFT);
The declaration of addr is below here and, even so, it would be uninitialised ...
+ unsigned int nr_pages; unsigned long addr;
-- Cheers, Stephen Rothwell