Thread (27 messages) 27 messages, 5 authors, 2017-04-27

Re: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings

From: Shuah Khan <shuah@kernel.org>
Date: 2017-04-24 19:48:56
Also in: linux-gpio, lkml

On 04/24/2017 09:57 AM, David Laight wrote:
From: Linuxppc-dev Michael Ellerman
quoted
Shuah Khan [off-list ref] writes:
quoted
Add override for lib.mk clean to fix the following warnings from clean
target run.

Makefile:44: warning: overriding recipe for target 'clean'
../lib.mk:55: warning: ignoring old recipe for target 'clean'

Signed-off-by: Shuah Khan <redacted>
---
 tools/testing/selftests/x86/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
index 38e0a9c..4d27550 100644
--- a/tools/testing/selftests/x86/Makefile
+++ b/tools/testing/selftests/x86/Makefile
@@ -40,8 +40,9 @@ all_32: $(BINARIES_32)

 all_64: $(BINARIES_64)

-clean:
+override define CLEAN
 	$(RM) $(BINARIES_32) $(BINARIES_64)
+endef
Simpler as:

EXTRA_CLEAN := $(BINARIES_32) $(BINARIES_64)
Actually for builds that insist on crapping all over the source tree I've used:

clean:
	rm -rf `cat .cvsignore 2>/dev/null`

	David
This will have to be done as a separate change. The warnings I am fixing
are related to common clean target in lib.mk and the need to override.

thanks,
-- Shuah
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help