Thread (7 messages) 7 messages, 3 authors, 2017-04-25

Re: [PATCH] hwmon: (ibmpowernv) Add min/max attributes and current sensors

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2017-04-22 06:12:02
Also in: linux-hwmon, lkml

Shilpasri G Bhat [off-list ref] writes:
On 04/21/2017 05:17 PM, C=C3=A9dric Le Goater wrote:
quoted
On 04/21/2017 06:31 AM, Shilpasri G Bhat wrote:
quoted
diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c
index 6d2e660..1f329fa8 100644
--- a/drivers/hwmon/ibmpowernv.c
+++ b/drivers/hwmon/ibmpowernv.c
@@ -65,7 +66,8 @@ enum sensors {
 	{"fan", "ibm,opal-sensor-cooling-fan"},
 	{"temp", "ibm,opal-sensor-amb-temp"},
 	{"in", "ibm,opal-sensor-power-supply"},
-	{"power", "ibm,opal-sensor-power"}
+	{"power", "ibm,opal-sensor-power"},
+	{"curr"}, /* Follows newer device tree compatible ibm,opal-sensor */
=20
why isn't there a compatible string ?=20
Skiboot exports "ibm,opal-sensor" as compatible string for all the inband
sensors. Now if I define that as the compatible string here, then all the
sensors would get identified as "curr" type of sensor by the driver.
So fix it in skiboot?

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help