Re: [PATCH v3 7/7] powerpc: kprobes: remove duplicate saving of msr
From: Masami Hiramatsu <mhiramat@kernel.org>
Date: 2017-04-19 14:43:59
Also in:
lkml
On Wed, 19 Apr 2017 18:21:06 +0530 "Naveen N. Rao" [off-list ref] wrote:
set_current_kprobe() already saves regs->msr into kprobe_saved_msr. Remove the redundant save.
Looks good to me. Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org> Thank you,
quoted hunk ↗ jump to hunk
Signed-off-by: Naveen N. Rao <redacted> --- arch/powerpc/kernel/kprobes.c | 1 - 1 file changed, 1 deletion(-)diff --git a/arch/powerpc/kernel/kprobes.c b/arch/powerpc/kernel/kprobes.c index 067e9863bfdf..5c0a1ffcbcf9 100644 --- a/arch/powerpc/kernel/kprobes.c +++ b/arch/powerpc/kernel/kprobes.c@@ -272,7 +272,6 @@ int __kprobes kprobe_handler(struct pt_regs *regs) */ save_previous_kprobe(kcb); set_current_kprobe(p, regs, kcb); - kcb->kprobe_saved_msr = regs->msr; kprobes_inc_nmissed_count(p); prepare_singlestep(p, regs); kcb->kprobe_status = KPROBE_REENTER;-- 2.12.1
-- Masami Hiramatsu [off-list ref]