Re: [PATCH v5 7/7] perf report: Show branch type in callchain entry
From: Jiri Olsa <hidden>
Date: 2017-04-19 14:15:15
Also in:
lkml
From: Jiri Olsa <hidden>
Date: 2017-04-19 14:15:15
Also in:
lkml
On Wed, Apr 19, 2017 at 11:48:14PM +0800, Jin Yao wrote: SNIP
+static int branch_type_str(struct branch_type_stat *stat,
+ char *bf, int bfsize)
+{
+ int i, j = 0, printed = 0;
+ u64 total = 0;
+
+ for (i = 0; i < PERF_BR_MAX; i++)
+ total += stat->counts[i];
+
+ if (total == 0)
+ return 0;
+
+ if (stat->jcc_fwd > 0)
+ printed += count_str_printf(j++, "JCC forward",
+ bf + printed, bfsize - printed);
+
+ if (stat->jcc_bwd > 0)
+ printed += count_str_printf(j++, "JCC backward",
+ bf + printed, bfsize - printed);
please move that multiline conditional code inside {} brackets
thanks,
jirka