Thread (10 messages) flat view 10 messages, 3 authors, 2017-03-21

Re: [PATCH 1/3] cxl: Re-factor cxl_pci_afu_read_err_buffer()

From: Vaibhav Jain <hidden>
Date: 2017-03-21 04:39:19

Thanks for reviewing Andrew !!

Andrew Donnellan [off-list ref] writes:
quoted
+
+	/* max we can copy in one read is PAGE_SIZE */
+	if (aligned_length > ERR_BUFF_MAX_COPY_SIZE) {
I'm not sure if the name ERR_BUFF_MAX_COPY_SIZE makes sense here any
more.
It might make sense to change to PAGE_SIZE. Will do the change in
susequent revision.

-- 
Vaibhav Jain [off-list ref]
Linux Technology Center, IBM India Pvt. Ltd.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help