Thread (1 message) 1 message, 1 author, 2017-03-14

Re: ioctl structs differ from x86_64?

From: Harshal Patil <hidden>
Date: 2017-03-14 10:59:35

<div class=3D"socmaildefaultfont" dir=3D"ltr" style=3D"font-family:Arial, H=
elvetica, sans-serif;font-size:10.5pt" ><div dir=3D"ltr" >Adding Pradipta a=
nd Christy.</div>
<div dir=3D"ltr" ><div class=3D"socmaildefaultfont" dir=3D"ltr" style=3D"fo=
nt-family:Arial;font-size:10.5pt" ><div class=3D"socmaildefaultfont" dir=3D=
"ltr" style=3D"font-family:Arial;font-size:10.5pt" ><div dir=3D"ltr" style=
=3D"margin-top: 20px;" ><div style=3D"font-size: 12pt; font-weight: bold; f=
ont-family: sans-serif; color: #7C7C5F;" >Harshal&nbsp;Patil</div>
<div style=3D"font-size: 8pt; font-family: sans-serif; margin-top: 10px;" >=
<div><span style=3D"font-weight: bold; color: #336699;" >E-mail: </span><a =
href=3D"mailto:harshal.patil@in.ibm.com" style=3D"color: #555" >harshal.pat=
il@in.ibm.com</a></div></div></div></div></div></div>
<div dir=3D"ltr" >&nbsp;</div>
<div dir=3D"ltr" >&nbsp;</div>
<blockquote data-history-content-modified=3D"1" data-history-expanded=3D"1"=
 dir=3D"ltr" style=3D"border-left:solid #aaaaaa 2px; margin-left:5px; paddi=
ng-left:5px; direction:ltr; margin-right:0px" >----- Original message -----=
<br>From: Harshal Patil/India/IBM<br>To: linuxppc-dev@lists.ozlabs.org<br>C=
c: Sudipto Ghosh/India/IBM@IBMIN<br>Subject: ioctl structs differ from x86=
=5F64?<br>Date: Tue, Mar 14, 2017 4:07 PM<br>&nbsp;
<div dir=3D"ltr" style=3D"font-family:Arial, Helvetica, sans-serif;font-siz=
e:10.5pt" ><div dir=3D"ltr" style=3D"font-family:Arial, Helvetica, sans-ser=
if;font-size:10.5pt" ><div dir=3D"ltr" >Hello,</div>
<div dir=3D"ltr" >&nbsp;</div>
<div dir=3D"ltr" >I am looking into a bug,&nbsp;<a href=3D"https://bugzilla=
.linux.ibm.com/show=5Fbug.cgi?id=3D152493" target=3D"=5Fblank" >https://bug=
zilla.linux.ibm.com/show=5Fbug.cgi?id=3D152493</a>&nbsp;( external mirror i=
s at,&nbsp;<a href=3D"https://github.com/opencontainers/runc/issues/1364" t=
arget=3D"=5Fblank" >https://github.com/opencontainers/runc/issues/1364</a>)=
&nbsp;</div>
<div dir=3D"ltr" >&nbsp;</div>
<div dir=3D"ltr" >Recently in runc&nbsp;code, they added this code&nbsp;<a =
href=3D"https://github.com/opencontainers/runc/commit/eea28f480db435dbef4a2=
75de9776b9934818b8c#diff-5f5c07d0cab3ce2086437d3d43c0d25fR155" target=3D"=
=5Fblank" >https://github.com/opencontainers/runc/commit/eea28f480db435dbef=
4a275de9776b9934818b8c#diff-5f5c07d0cab3ce2086437d3d43c0d25fR155</a>. As yo=
u can see they set -onlcr&nbsp;to get rid of \r (line no. 164). Golang,&nbs=
p;in which runc is written, doesn't have any bindings for ioctls. &nbsp;Thi=
s means you have to invoke C code directly (that's what they are doing ther=
e).</div>
<div dir=3D"ltr" >&nbsp;</div>
<div dir=3D"ltr" >Our guess is the ioctls in ppc64le differ than x86=5F64, =
and thats why the code which is clearing onclr bit (<a href=3D"https://gith=
ub.com/opencontainers/runc/commit/eea28f480db435dbef4a275de9776b9934818b8c#=
diff-5f5c07d0cab3ce2086437d3d43c0d25fR164" target=3D"=5Fblank" >https://git=
hub.com/opencontainers/runc/commit/eea28f480db435dbef4a275de9776b9934818b8c=
#diff-5f5c07d0cab3ce2086437d3d43c0d25fR164</a>) is failing on ppc64le but w=
orks fine on x86=5F64.&nbsp;</div>
<div dir=3D"ltr" >&nbsp;</div>
<div dir=3D"ltr" >Any pointers on the possible solution would be really hel=
pful.&nbsp;</div>
<div dir=3D"ltr" >&nbsp;</div>
<div dir=3D"ltr" >Thanks,</div>
<div dir=3D"ltr" ><div dir=3D"ltr" style=3D"font-family:Arial;font-size:10.=
5pt" ><div dir=3D"ltr" style=3D"font-family:Arial;font-size:10.5pt" ><div d=
ir=3D"ltr" style=3D"margin-top: 20px;" ><div style=3D"font-size: 12pt; font=
-weight: bold; font-family: sans-serif; color: #7C7C5F;" >Harshal&nbsp;Pati=
l</div>
<div style=3D"font-size: 8pt; font-family: sans-serif; margin-top: 10px;" >=
<div><span style=3D"font-weight: bold; color: #336699;" >E-mail: </span><a =
href=3D"mailto:harshal.patil@in.ibm.com" style=3D"color: #555" target=3D"=
=5Fblank" >harshal.patil@in.ibm.com</a></div></div></div></div></div></div>=
</div></div></blockquote>
<div dir=3D"ltr" >&nbsp;</div></div><BR>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help