Re: [PATCH] powerpc: kprobes: convert __kprobes to NOKPROBE_SYMBOL()

On 2017/03/08 09:42AM, Masami Hiramatsu wrote:

On Wed,  8 Mar 2017 02:09:29 +0530
"Naveen N. Rao" [off-list ref] wrote:

quoted

Along similar lines as commit 9326638cbee2 ("kprobes, x86: Use
NOKPROBE_SYMBOL() instead of __kprobes annotation"), convert __kprobes
annotation to either NOKPROBE_SYMBOL() or nokprobe_inline. The latter
forces inlining, in which case the caller needs to be added to
NOKPROBE_SYMBOL().

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

OK, this is a good starting point so far. please consider that those
functions really have to be protected by kprobes. As you can see on x86,

Yes, I've only converted static functions to nokprobe_inline and 
confirmed that their callers are protected. I also verified that none of 
these show up in kallsyms.

I allowed some functions to be kprobed by commit 7ec8a97a990d ("kprobes/x86:
Allow probe on some kprobe preparation functions").
Maybe on powerpc, those arch_* functions also be probed safely, since
those are not kicked in the context of breakpoint interruption.

Nice, thanks for the pointer. I will consider that as part of the kprobe 
blacklisting updates I have for powerpc.

Regards,
Naveen